Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaults plugins to empty array #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Defaults plugins to empty array #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion react/ConnectedUIRouter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ export function ConnectedUIRouter({
// services plugin is necessary for UIRouter to function
router.current.plugin(servicesPlugin);
// apply all the plugins that are passed via props
plugins.forEach(plugin => router.current.plugin(plugin));
(plugins || []).forEach(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows plugins to be optionally set via setting directly on the router instance itself in the same way that states can be set via props or directly on the instance.

plugin => router.current.plugin(plugin)
);
// apply the newly created redux plugin
router.current.plugin(reduxPlugin.current);

Expand Down