@uirouter/react and @uirouter/angularjs should be peerDependencies #4
Comments
…er dependencies Since @uirouter/core is stateful, having a different version of @uirouter/angularjs or @uirouter/react in the user project would cause some very hard to debug issues. Moving them to peer dependencies instead forces the versions to be the same. Also, the interfaces to the core API are now safely available in the user project. Fixes ui-router#4.
|
@christopherthielen I'm also having a similar issue with this. Currently I don't see how we can practically use @uirouter/react-hybrid without referencing @uirouter/react or @uirouter/angular for the typescript types alone. But in our case we are also using angular state events still and swapping to this wont work per the examples because services.q ends up undefined and I get: TypeError: Cannot read property 'when' of undefined Is there any work around for these issues that you know of? |
|
I guess I don't understand the problem. Because the package has a hard dependency on the supported versions, you don't have to add them at the top level. Additionally, they should be hoisted to the top level by either yarn or npm so the typings should be available. Can you provide further details? |
@uirouter/reactand@uirouter/angularjsare included directly in this project. However, if one of these libraries are included in thepackage.jsonof the app, this causes a clash because all the globals (for example location services, $q, etc.) will not be populated.The text was updated successfully, but these errors were encountered: