Skip to content

Synchronous redirects from onBefore can cause infinite redirect loop #6

Closed
@christopherthielen

Description

@christopherthielen

88052bf added 20+ redirect loop detection, but it only was checked

  • when the redirected transition was run
  • after the sync hooks were processed

This meant a synchronous hook (onBefore) which returned a redirect could avoid the loop detection.

Moving this logic to the Transition.redirect() function should detect the 20+ loops at a more appropriate time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions