-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OnUiParamsChanged, OnUiExit interfaces instead of Ng2Component #788
Comments
stnor
changed the title
Create OnParamsChanged, CanExit interfaces instead of Ng2Component
Create OnUiParamsChanged, OnUiExit interfaces instead of Ng2Component
May 14, 2020
That sounds good to me. Would you like to take a shot at a PR? |
Sure, I'll give it a try later this week. |
@christopherthielen Should I remove, deprecate or leave "Ng2Component" as is? |
stnor
added a commit
to stnor/ui-router-angular
that referenced
this issue
May 28, 2020
…stead of Ng2Component
stnor
added a commit
to stnor/ui-router-angular
that referenced
this issue
May 28, 2020
…stead of Ng2Component
PR #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice with separate interface exports for the hooks, and with a nice naming, such as:
As it is right now the NG2Component interface really does not add any declarative meaning for a person using the framework, imho:
I don't get why a user-exposed interface has this design with all optional methods. I feel that its better to have one interface per hook and not use the optional (?) syntax.
Any chance of getting this? I could create my own interfaces, but feel it's better if it's in the framework. Thanks.
The text was updated successfully, but these errors were encountered: