-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Angular 16 support #589
Conversation
Taking care of ui-router/sample-app-angular-hybrid#913 |
hmm looks like the example is failing. |
I figure it out, you need to update:
|
Thanks so much. If it's OK I will pick it up after my vacation, at the 2nd week of August. |
Testing locally, with your recommended changes, the |
Hi, can you change the downstream test to uirouter I just merged it. |
Thanks @wawyed, I'll take care of it. |
* preparation work for angular 16 support * update to @uirouter/angular@12.0.0 * Update to ui-router/angular@12 * Temporarily point to the Angular 16 update PR * update packages * update rxjs * change back to point to sample-app-angular-hybrid
This PR implements Angular 16 support.
Once the sample app (ui-router/sample-app-angular-hybrid#914) is updated, this PR is also mergeable
Fixes #588