fix: stop fallback matching when a route is skipped during SSR#113
Merged
fix: stop fallback matching when a route is skipped during SSR#113
Conversation
When skipLoaders is true and a route with a loader would match the current path, return a SKIPPED sentinel instead of null. This prevents catch-all routes from incorrectly matching during SSR, which caused a 404 flash on hydration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change the docs site and examples to use `path: "/*"` for catch-all routes instead of pathless routes. Path-based catch-all routes behave correctly during SSR because they don't match when the pathname is unknown. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipLoaders: trueand a route with a loader would match the current path, return a SKIPPED sentinel instead ofnull. This prevents catch-all routes from incorrectly matching during SSR, which caused a flash on hydration.path: "/*"for catch-all routes instead of pathless routes.Test plan
pnpm test:run— 226 tests passpnpm typecheck— no type errorspnpm build— builds successfully (including docs site with updated routes)🤖 Generated with Claude Code