fix: Fix hubblo-org#175

- Remove carriage return in process cmdline.

src/exporters/mod.rs

@@ -692,7 +692,7 @@ impl MetricGenerator {
             attributes.insert("exe".to_string(), exe.clone());
 
             if let Some(cmdline_str) = cmdline {
-                attributes.insert("cmdline".to_string(), cmdline_str.replace('\"', "\\\""));
+                attributes.insert("cmdline".to_string(), utils::filter_cmdline(&cmdline_str));
 
                 if self.qemu {
                     if let Some(vmname) = utils::filter_qemu_cmdline(&cmdline_str) {

src/exporters/utils.rs

@@ -5,6 +5,16 @@ use clap::crate_version;
 use docker_sync::Docker;
 use k8s_sync::{errors::KubernetesError, kubernetes::Kubernetes};
 
+/// Returns a cmdline String filtered from potential characters that
+/// could break exporters output.
+///
+/// Here we replace:
+/// 1. Double quote by backslash double quote.
+/// 2. Remove carriage return.
+pub fn filter_cmdline(cmdline: &str) -> String {
+    cmdline.replace('\"', "\\\"").replace('\n', "")
+}
+
 /// Returns an Option containing the VM name of a qemu process.
 ///
 /// Then VM name is extracted from the command line.
@@ -81,6 +91,16 @@ mod tests {
         let cmdline = "qemu-system-x86_64,file=/var/lib/libvirt/qemu/domain-1-fedora33/master-key.aes-object-Sguest=";
         assert_eq!(filter_qemu_cmdline(cmdline), None);
     }
+
+    #[test]
+    // Fix bug https://github.com/hubblo-org/scaphandre/issues/175
+    fn test_filter_cmdline_with_carriage_return() {
+        let cmdline = "bash-csleep infinity;\n> echo plop";
+        assert_eq!(
+            filter_cmdline(cmdline),
+            String::from("bash-csleep infinity;> echo plop")
+        );
+    }
 }
 
 pub fn get_docker_client() -> Result<Docker, std::io::Error> {