Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected MSVC condition in cmake for msvc 2010 #88

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Corrected MSVC condition in cmake for msvc 2010 #88

merged 1 commit into from
Nov 14, 2017

Conversation

wenqing
Copy link
Member

@wenqing wenqing commented Nov 9, 2017

as titled. For msvc 2010, if (COMPILER_IS_MSVC), which is set by checking CMAKE_C_COMPILER_ID, does not work.

@wenqing wenqing changed the title Coorected MSVC condition in cmake for msvc 2010 Corrected MSVC condition in cmake for msvc 2010 Nov 9, 2017
@bilke
Copy link
Member

bilke commented Nov 9, 2017

I think it is enough to check for MSVC.

@wenqing
Copy link
Member Author

wenqing commented Nov 10, 2017

@bilke Thanks. Changed accordingly.

@bilke bilke merged commit 3ebcbbc into ufz:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenqing @bilke