Minkley burgers fixes #46
Conversation
|
|
||
| SolidBurgers::~SolidBurgers() | ||
| { | ||
| smath = NULL; |
There was a problem hiding this comment.
where is the memory of smath released?
|
@nagelt see Jenkins result. maybe the reference result has to be updated |
|
@norihiro-w There's a pull-request open for that .. |
|
sorry I missed it... |
|
UJG-M/m_sdc is fixed now. But I realized now that WW-MPI/thm_quad/thm_quad is also failing due to time out. I think this is the last one to be fixed. |
| if (line_string.find("$AUTOMATIC_NEWTON_DAMPING") != string::npos) // NW | ||
| { | ||
| line.str(GetLineFromFile1(num_file)); | ||
| line >> automatic_damping_tolerance; //if NR error decreases by less than this factor, the next step will be dampened |
There was a problem hiding this comment.
Suggest to remove automatic_ because that the damping factor is specified not calculated.
There was a problem hiding this comment.
But it's automatically switched on or off : )
There was a problem hiding this comment.
i agree with wenqing. the name is confusing
There was a problem hiding this comment.
Yes, the damping should be determined by error. However, the damping factor has to be specified in advance. Actually, the tolerance of automatic_damping_tolerance should be the same as to that of the Newton such that the damping is applied when a Newton step error fails in quadratic convergence (in the strict manner) or the error increases.
If automatic_damping is used, one may think that he only need to give the keyword to enable the method. Anything else including when damping, and the value of damping are conducted by the program automatically (e.g by linear search).
There was a problem hiding this comment.
Convinced. I suggest to first fix the general control of the NR scheme (which tolerances for which convergence measures) though and then an "automatic damping" (two follow-up PRs). All this new keyword does now is transfer the formerly hard-coded damping to input file control.
|
@nagelt please add OGS copyright header to the new source files and remove some old codes which you commented out, if there is no particular reason to keep them. then I think this PR is ready for being merged |
Added output message. Bugfix in plasticity tolerance keyword. Renamed Damping keyword and associated variables.
nagelt
force-pushed
the
Minkley_Burgers_Fixes
branch
from
468877e
to
ce27450
Compare
This PR introduces two solid material models and tests. The changes introduced are confined to these specific material models.