[BUGFIX] Critical bugfix NONLINEAR time stepping #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luates non-linear iterations.
|
i am not understanding the bug you explained. Do you mean (1) |
| @@ -583,7 +583,7 @@ IterationType::type convertIterationType(const std::string& str) | |||
| { | |||
| if (str.find("LINEAR")!=std::string::npos) | |||
| return IterationType::LINEAR; | |||
| else if (str.find("NONLINEAR")!=std::string::npos) | |||
| else if (str.find("NONLIN")!=std::string::npos) | |||
There was a problem hiding this comment.
why not make exact comparisons? like str.compare("NONLINEAR")==0 or str=="NONLINEAR"?
|
@norihiro-w the bug is, that if you have "NONLINEAR" in the .tim file, ogs will still use |
norihiro-w
added a commit
that referenced
this pull request
Mar 4, 2016
[BUGFIX] Critical bugfix NONLINEAR time stepping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to select self-adaptive time step which evaluates non-linear iterations.
before, it would select linear steps, as it found "linear" also in "nonlinear".