Enable $EPSILON for ST that is is consistent with BCs #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new: memory for array for maximum size.
new: memory for array for maximum size.
Consisten with BC: The user is getting a choice to specify the tolreance in ST or taking the default or using the one from GLI.
wenqing
reviewed
Dec 7, 2018
FEM/rf_st_new.cpp
Outdated
| @@ -3371,16 +3379,25 @@ void CSourceTerm::SetNOD() | |||
| 11/2007 JOD | |||
| last modification: | |||
| **************************************************************************/ | |||
| void CSourceTermGroup::SetSurfaceNodeVector(Surface* m_sfc, std::vector<long>& sfc_nod_vector) | |||
| void CSourceTermGroup::SetSurfaceNodeVector(Surface* m_sfc, std::vector<long>& sfc_nod_vector, CSourceTerm* st) | |||
There was a problem hiding this comment.
You can use a double argument here instead of CSourceTerm* For example,
::SetSurfaceNodeVector(Surface* m_sfc, std::vector<long>& sfc_nod_vector, const double tolerance)
wenqing
approved these changes
Dec 13, 2018
FEM/rf_st_new.cpp
Outdated
| @@ -3284,10 +3292,10 @@ void CSourceTermGroup::SetSFC(CSourceTerm* m_st, const int ShiftInNodeVector) | |||
| { | |||
| GEOLIB::Surface const& sfc(*(dynamic_cast<GEOLIB::Surface const*>(m_st->getGeoObj()))); | |||
| std::cout << "Surface " << m_st->geo_name << ": " << sfc.getNTriangles() << "\n"; | |||
| SetSurfaceNodeVector(&sfc, sfc_node_ids); | |||
| SetSurfaceNodeVector(&sfc, sfc_node_ids, m_st); | |||
There was a problem hiding this comment.
Here change m_st to st->epsilon.
FEM/rf_st_new.cpp
Outdated
|
|
||
| /* | ||
| SetSurfaceNodeVector(m_sfc, sfc_nod_vector); | ||
| SetSurfaceNodeVector(m_sfc, sfc_nod_vector,m_st); |
There was a problem hiding this comment.
Here change m_st to st->epsilon.
FEM/rf_st_new.cpp
Outdated
| } | ||
|
|
||
| void CSourceTermGroup::SetSurfaceNodeVector(GEOLIB::Surface const* sfc, std::vector<std::size_t>& sfc_nod_vector) | ||
| void CSourceTermGroup::SetSurfaceNodeVector(GEOLIB::Surface const* sfc, std::vector<std::size_t>& sfc_nod_vector, CSourceTerm* st) |
There was a problem hiding this comment.
replace CSourceTerm* st with const double tolerance.
FEM/rf_st_new.cpp
Outdated
| { | ||
| double computed_search_length = m_msh->getSearchLength(); | ||
| if (st->epsilon != -1) |
There was a problem hiding this comment.
replace if (st->epsilon != -1) with if ( tolerance !=-1)
FEM/rf_st_new.cpp
Outdated
| { | ||
| double computed_search_length = m_msh->getSearchLength(); | ||
| if (st->epsilon != -1) |
There was a problem hiding this comment.
replace if (st->epsilon != -1) with if ( tolerance !=-1)
There was a problem hiding this comment.
Why should we make it different to the BC. There we already included double epsilon;
|
so I leave the epsilon change the everything according to your suggestions. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the opportunity to specify the tolerance in ST directly. Taking the default value or using the tolerance from GLI is still enabled.