Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean CFiniteElementVec::GlobalAssembly_RHS() #102

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Clean CFiniteElementVec::GlobalAssembly_RHS() #102

merged 4 commits into from
Jun 28, 2018

Conversation

wenqing
Copy link
Member

@wenqing wenqing commented Jun 19, 2018 •
edited
Loading

  1. Moved the Bishop coefficient calculation to CSolidProperties to remove the source code duplication.
  2. Removed source code duplication in checking element for excavation modelling.
  3. Removed unused source code.
  4. Reduced the if-conditions inside the loop to compute the nodal pore pressures for the coupling term.

@wenqing
Copy link
Member Author

wenqing commented Jun 22, 2018

@norihiro-w Do you have any any comment? If not, I am going to merge it.

@norihiro-w
Copy link
Contributor

looks okay

@bilke
Copy link
Member

bilke commented Jun 28, 2018

@wenqing I restarted the Jenkins job and now it ran successfully.

@wenqing
Copy link
Member Author

wenqing commented Jun 28, 2018

@bilke Thanks.

@wenqing wenqing merged commit b979ad9 into ufz:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenqing @norihiro-w @bilke