[RM] Alternative mass balance #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
reviewed
Apr 22, 2020
| <type>Dirichlet</type> | ||
| <parameter>pressure_bc</parameter> | ||
| </boundary_condition> | ||
| <!--boundary_condition> werden automatisch neumann 0 RB |
There was a problem hiding this comment.
Drop the commented block. Comments in English please ;)
endJunction
approved these changes
Apr 22, 2020
skai95
force-pushed
the
alternative_mass_balance
branch
from
fa14711
to
46ecb25
Compare
TomFischer
reviewed
Apr 23, 2020
| <value>0.3</value> | ||
| </parameter> | ||
| <!-- Model parameters --> | ||
| <!--parameter> |
There was a problem hiding this comment.
Can this commented parameter be removed? If not, please drop a short message here why it is necessary to keep it.
TomFischer
reviewed
Apr 23, 2020
| <type>Constant</type> | ||
| <value>0.5</value> | ||
| </property> | ||
| <!--property> |
There was a problem hiding this comment.
Can this commented property be removed? If not, please drop a short message here why it is necessary to keep it.
TomFischer
reviewed
Apr 23, 2020
| @@ -0,0 +1,25 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Is this pvd-file used somewhere? Can it be deleted?
TomFischer
reviewed
Apr 23, 2020
| @@ -0,0 +1,16 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Is this pvd-file used somewhere? Can it be deleted?
TomFischer
approved these changes
Apr 23, 2020
…iles, added alternative_mass_balance_anzInterval_10 block to Tests.cmake
…masslumping, Richards_2d_geometry_OBSERVATION_POINT and deformation_dependent_porosity_swelling tests
skai95
force-pushed
the
alternative_mass_balance
branch
from
46ecb25
to
6885b2e
Compare
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #