Add prism element type to structure mesh generator tool. #2903
Conversation
| case MeshLib::MeshElemType::PRISM: | ||
| mesh.reset(MeshLib::MeshGenerator::generateRegularPrismMesh( | ||
| n_subdivision[0], n_subdivision[1], n_subdivision[2], vec_dx[0], | ||
| vec_dx[1], vec_dx[2])); |
There was a problem hiding this comment.
Why is vec_dx passed here and vec_div in other calls?
There was a problem hiding this comment.
There doesn't exist a corresponding interface in MeshLib/MeshGenerators/MeshGenerator.h.
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, you are right. There is an interface that takes the length and the number of subdivisions.
The other generator functions take BaseLib::ISubdivision as a parameter. An overload for the generateRegularPrismMesh that takes BaseLib::ISubdivision doesn't exist. So I have chosen the above function without a special reason. I'll change it to the suggested function to be a bit more consistent to the other generator functions.
TomFischer
force-pushed
the
AddPrismElementTypeToStructureMeshGenerator
branch
2 times, most recently
from
ed2ff57
to
0c3a638
Compare
|
@TomFischer ThirdParty/cmake-modules was changed (accidentally I guess...). |
Yes, this was an accident. I'll fix it. |
TomFischer
force-pushed
the
AddPrismElementTypeToStructureMeshGenerator
branch
from
0c3a638
to
4427ab7
Compare
|
OpenGeoSys development has been moved to GitLab. |
This allows to generate tests for the prism element.
The feature is tested already in
Tests/MeshLib/TestMeshGenerator.cppCommand line help is updated.