Add bulk element mappings for triangles. #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
reviewed
Apr 14, 2020
| /// local coordinates of the tri face. | ||
| /// \param tri the tri element | ||
| /// \param face_id the id of the tri face the point will be mapped on | ||
| /// \param wp the gauss point of the lower dimensional element |
There was a problem hiding this comment.
Minor; Would call it integration point at least.
Better would be to call it something like local coordinate of the line element. (and then to pass only the coordinates w/o the integration weight.) But this is a long story...
endJunction
approved these changes
Apr 14, 2020
wenqing
approved these changes
Apr 14, 2020
| return MathLib::Point3d{ | ||
| std::array<double, 3>{{0.0, 1 - wp[0], 0.0}}}; | ||
| default: | ||
| OGS_FATAL("Invalid face id '%u' for the tri.", face_id); |
There was a problem hiding this comment.
Suggested change
| OGS_FATAL("Invalid face id '%u' for the tri.", face_id); | |
| OGS_FATAL("Invalid face id '{:d}' for the tri.", face_id); |
There was a problem hiding this comment.
Yes, you are right. Will fix it tomorrow.
TomFischer
force-pushed
the
AddFurtherBulkElementMappings
branch
from
9e440dd to
b34d242
Compare
TomFischer
force-pushed
the
AddFurtherBulkElementMappings
branch
2 times, most recently
from
94c3a14 to
c1703dc
Compare
|
I don't see the reason for the doxygen warning: Seems to be a false positive? |
TomFischer
force-pushed
the
AddFurtherBulkElementMappings
branch
from
c1703dc to
5179a17
Compare
This is necessary because of a doxygen bug in documenting overloaded functions.
3 tasks
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I created a pdf. The question is where to put the sketches?