Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] ogs_add_library()-function #2881

Merged
merged 8 commits into from
Mar 27, 2020
Merged

[CMake] ogs_add_library()-function #2881

merged 8 commits into from
Mar 27, 2020

Conversation

bilke
Copy link
Member

@bilke bilke commented Mar 27, 2020

Added CMake-function ogs_add_library() as a drop-in replacement for the add_library()-function.

The function takes care of compiler switches (currently warning level only), enabling PCH and installing shared libraries. This makes it easier for developers creating new libraries (just call the new function with your source file list and you are done).

  1. Feature description was added to the changelog

@bilke bilke marked this pull request as ready for review March 27, 2020 14:51
@bilke bilke requested a review from endJunction March 27, 2020 14:54
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏩ when green

@bilke
Copy link
Member Author

bilke commented Mar 27, 2020

As usual:

ogs-2D_Adaptive_dt_ThermalConvection_constviscosityStaggeredScheme-time-vtkdiff (Failed)

@bilke bilke merged commit 79d553f into ufz:master Mar 27, 2020
@bilke bilke deleted the ogs_add_library branch March 27, 2020 15:38
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants