-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL] Distribute an independent mesh for chemical system #2851
[CL] Distribute an independent mesh for chemical system #2851
Conversation
I don't expect problems for parallel models. But to be sure please also prepare a parallel test. If you want I can test an example also at JUWELS supercomputer. |
|
||
auto const chemical_system_map = | ||
*_mesh.getProperties().template getPropertyVector<std::size_t>( | ||
"bulk_node_ids", MeshLib::MeshItemType::Node, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default bulk mesh will not have the bulk_node_ids
. (And it should not.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't realized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=> The chemical domain mesh must always be a subdomain mesh (not necessarily smaller).
Maybe it would be better to have a mesh property indicating where the chemical system should be solved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! One need apply the mesh tool identifySubdomain
to create a mesh file containing the property bulk_node_ids
, even in the case that chemical reactions take place over the entire domain. Also, the tag <mesh>
should no longer be optional.
As yet we don't have a benchmark run in parallel, because I have not yet touched parallel computing for local chemical calculation. |
2fcdd13
to
b8976be
Compare
The |
9955ab1
to
78f5f11
Compare
Please parallelize one of the benchmarks. If you have questions I can support you. |
Thanks in advance for your support. Parallel computing for solving chemical systems is on schedule. As yet I have no idea where to start. It would be great to get some instructions from your side. Let's discuss if you have time. |
78f5f11
to
06d2fd5
Compare
06d2fd5
to
1eab41e
Compare
1eab41e
to
12f5052
Compare
Rebased. |
OpenGeoSys development has been moved to GitLab. |
This pull request adds a mesh tag required under the tree of
<chemical system>
. With this change, one is able to restrict the place where chemical reactions take place within a specified subdomain. This utility prevents from performing unneeded chemical calculations within the subdomains where no chemical reactions take place, thereby boosting computational efficiency up.