Add output of fluxes to LiquidFlow process #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFischer
force-pushed
the
LiquidFlowFluxes
branch
5 times, most recently
from
f4de690 to
c1a07a3
Compare
- Forward the output folder and mesh vector from ProjectData to CreateLiquidFlow. - Create an optional SurfaceFluxData object.
TomFischer
force-pushed
the
LiquidFlowFluxes
branch
from
c1a07a3 to
00d6cf5
Compare
endJunction
reviewed
Jan 20, 2020
| @@ -121,5 +125,39 @@ void LiquidFlowProcess::computeSecondaryVariableConcrete(const double t, | |||
| x, _coupled_solutions); | |||
| } | |||
|
|
|||
| Eigen::Vector3d LiquidFlowProcess::getFlux( | |||
| std::size_t element_id, | |||
There was a problem hiding this comment.
Suggested change
| std::size_t element_id, | |
| std::size_t const element_id, |
endJunction
reviewed
Jan 20, 2020
| // according to the right hand rule | ||
| // for correct results it is necessary to multiply the normal with -1 | ||
| surface_element_normal *= -1; | ||
| auto getSurfaceNormal = |
There was a problem hiding this comment.
This is a variable, should be get_surface_normal.
Suggested change
| auto getSurfaceNormal = | |
| auto get_surface_normal = |
There was a problem hiding this comment.
struct { void operator() { } } get_surface_normal;
endJunction
approved these changes
Jan 20, 2020
|
Minor things only. If no review 'til tomorrow, merge it. |
TomFischer
force-pushed
the
LiquidFlowFluxes
branch
from
00d6cf5 to
2eaec2b
Compare
In 2d case the z component would be arbitrary when uninitialized.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flux calculation is now available for the LiquidFlow process. This works analogously to the other implementations in the HT-Process, HC-Process and groundwater flow process. Documentation already exists for this.