New MPL property: Brooks&Corey relative permeability #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scinopode
force-pushed
the
mpl_brooks_corey_relative_permeability
branch
2 times, most recently
from
bfafbc7 to
e7ad48a
Compare
Scinopode
force-pushed
the
mpl_brooks_corey_relative_permeability
branch
from
e7ad48a to
27dafff
Compare
TomFischer
reviewed
Sep 12, 2019
TomFischer
reviewed
Sep 12, 2019
| auto const exponent = | ||
| //! \ogs_file_param{prj__media__medium__properties__property__RelPermBrooksCorey__lambda} | ||
| config.getConfigParameter<double>("lambda"); | ||
| if (exponent == 0.) |
There was a problem hiding this comment.
The error message below is different from the check.
Suggested change
| if (exponent == 0.) | |
| if (exponent <= 0.) |
TomFischer
reviewed
Sep 12, 2019
TomFischer
reviewed
Sep 12, 2019
| const double min_relative_permeability_liquid, | ||
| const double min_relative_permeability_gas, | ||
| const double exponent) | ||
|
|
There was a problem hiding this comment.
The empty line not necessary.
TomFischer
reviewed
Sep 12, 2019
| ParameterLib::SpatialPosition const& pos, double const t) const | ||
| { | ||
| (void)primary_variable; | ||
| assert((primary_variable == Variable::liquid_saturation) && |
There was a problem hiding this comment.
Maybe it is better to check this also in the release version?
There was a problem hiding this comment.
not sure here, let's measure it!
There was a problem hiding this comment.
Talked with @Scinopode : The primary variable isn't user input. It is 'hard' coded in the process and mistakes should be detected while the development of a new process.
TomFischer
reviewed
Sep 12, 2019
| const double /*_min_relative_permeability_gas*/, | ||
| const double /*exponent*/ | ||
| ); | ||
| /// This method assigns a pointer to the meterial object that is the owner |
There was a problem hiding this comment.
Suggested change
| /// This method assigns a pointer to the meterial object that is the owner | |
| /// This method assigns a pointer to the material object that is the owner |
|
@Scinopode Please add this and the saturation to the Changelog!! |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brooks&Corey relative permeability property for the generalized material property library.