Replaced the material parameters of ThermoHydroMechanics with MPL #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFischer
reviewed
Aug 16, 2019
|
|
||
| // | ||
| // temperature equation, pressure part | ||
| // | ||
| KTp.noalias() += K_over_mu * rho_f * C_f * N_T.transpose() * | ||
| (dNdx_T * T).transpose() * dNdx_T * w; | ||
| KTp.noalias() += fluid_density * c_f * N_T.transpose() * |
There was a problem hiding this comment.
Just out of curiosity: Why did you reorder the calculation?
There was a problem hiding this comment.
Because K_over_mu is changed to matrix now.
TomFischer
approved these changes
Aug 16, 2019
endJunction
reviewed
Aug 16, 2019
| auto const& b = _process_data.specific_body_force; | ||
| auto const& identity2 = MathLib::KelvinVector::Invariants< | ||
| MathLib::KelvinVector::KelvinVectorDimensions< | ||
| DisplacementDim>::value>::identity2; | ||
|
|
||
| //TODO: Change dT to time step wise increment |
There was a problem hiding this comment.
Suggested change
| //TODO: Change dT to time step wise increment | |
| // TODO (wenqing): Change dT to time step wise increment |
|
@TomFischer I did the changes manually. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled.