Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydroMechanics non-equilibrium initial states. #2561

Closed
wants to merge 6 commits into from
Closed

HydroMechanics non-equilibrium initial states. #2561

wants to merge 6 commits into from

Conversation

endJunction
Copy link
Member

@endJunction endJunction commented Jul 9, 2019

Adding same non-equilibrium initial states as for the SmallDeformation process ##2501.

Meanwhile the theoretical ideas were developed further and this is only for the comparison with the next new implementation and also provides the project files/tests. The new idea is to include the non-equilibrium in the residuum.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

@@ -0,0 +1,3 @@
Non-equilibrium initial state variables which are not explicitly in equilibrium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not explicitly --> implicitly.

@wenqing
Copy link
Member

wenqing commented Jul 17, 2019

Will the changes in the local assembler be in another PR?

@endJunction
Copy link
Member Author

Yes, the F^{oob} (out of balance forces) formulation will follow in other PR.

@@ -188,13 +188,45 @@ std::unique_ptr<Process> createHydroMechanicsProcess(
config.getConfigParameter<double>(
"reference_temperature", std::numeric_limits<double>::quiet_NaN());

// Non-equilibrium variables
ParameterLib::Parameter<double> const* nonequilibrium_stress = nullptr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: Why not ´unique_ptr`?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a non-owning optional parameter.

@@ -97,6 +101,12 @@ struct HydroMechanicsProcessData
ParameterLib::Parameter<double> const& porosity;
/// Solid's density. A scalar quantity, ParameterLib::Parameter<double>.
ParameterLib::Parameter<double> const& solid_density;

/// Optional, non-equilibrium stress parameter.
ParameterLib::Parameter<double> const* const nonequilibrium_stress;
Copy link
Member

@TomFischer TomFischer Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ´unique_ptr´?

<Collection>
<DataSet timestep="0" group="" part="0" file="into_initial_state_pcs_0_ts_0_t_0.000000.vtu"/>
</Collection>
</VTKFile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the pvd file needed?

@TomFischer
Copy link
Member

Are the gml files needed? I didn´t see references in the prooject files.

Copy link
Member

@TomFischer TomFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks in general good. Some small things to discuss. After resolving the conflicts and when tests are green: ⏩

@wenqing
Copy link
Member

wenqing commented Aug 19, 2019

I guess that Tests/Data/HydroMechanics/InitialStates/pressure/Docu_HM_Non_Equilibrium_Initial_States.pdf is for the documentation of one benchmark. However the web content file, which should refer to that PDF is missing.

Copy link
Member

@wenqing wenqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a documentation of one benchmark is missing.

@@ -269,11 +302,11 @@ void HydroMechanicsLocalAssembler<ShapeFunctionDisplacement,

// pressure equation
local_rhs.template segment<pressure_size>(pressure_index).noalias() -=
laplace_p * p + storage_p * p_dot + Kpu * u_dot;
laplace_p * (p - p_neq) + storage_p * p_dot + Kpu * u_dot;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that every simulation starts from the previous status, whether which is equilibrium (may from the previous simulation) or non-equilibrium (specfied). Therefore p_neq should be p0, and local_rhs should not be changed. This is a suggestion for future change. The PR itself is OK with the current consideration.

@nagelt
Copy link
Member

nagelt commented Feb 14, 2020

This should be no longer needed with the CompensateInitial....

@endJunction
Copy link
Member Author

That's true, but I still didn't redo the test cases...

@ogsbot ogsbot closed this Jun 19, 2020
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

This issue / pull request was open before the GitLab migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants