Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurfaceFlux calculates now specific flux #2411

Merged
merged 14 commits into from
Mar 11, 2019
Merged

SurfaceFlux calculates now specific flux #2411

merged 14 commits into from
Mar 11, 2019

Conversation

TomFischer
Copy link
Member

No description provided.

endJunction
endJunction approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look in the ctests, though.

@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #2411 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2411      +/-   ##
==========================================
+ Coverage   32.59%   32.72%   +0.12%     
==========================================
  Files         530      530              
  Lines       20037    19850     -187     
  Branches     9503     9325     -178     
==========================================
- Hits         6532     6496      -36     
+ Misses      10167    10000     -167     
- Partials     3338     3354      +16
Impacted Files Coverage Δ
MathLib/Vector3.cpp 33.33% <0%> (-33.34%) ⬇️
MeshLib/CoordinateSystem.cpp 42.85% <0%> (-14.29%) ⬇️
GeoLib/SimplePolygonTree.cpp 61.9% <0%> (-4.77%) ⬇️
GeoLib/AnalyticalGeometry-impl.h 72.95% <0%> (-4.1%) ⬇️
...eStepping/Algorithms/EvolutionaryPIDcontroller.cpp 68.18% <0%> (-3.04%) ⬇️
GeoLib/SurfaceGrid.cpp 53.7% <0%> (-2.78%) ⬇️
...ng/Algorithms/IterationNumberBasedTimeStepping.cpp 76.74% <0%> (-2.33%) ⬇️
GeoLib/MinimalBoundingSphere.cpp 41.17% <0%> (-1.97%) ⬇️
GeoLib/Polyline.cpp 35.31% <0%> (-1.88%) ⬇️
MeshLib/MeshSurfaceExtraction.cpp 30.81% <0%> (-1.26%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64de79a...a7fbd39. Read the comment docs.

@TomFischer
[PL/SurfaceFlux] Readability: balance -> specific_flux.
76539ad
@TomFischer
[PL/SurfaceFlux] Divide flux per elem. by elem area.
e1915a2
@TomFischer
[T/ComponentTransport] Rename data_array in test.
300fef5 
Rename to better reflect the information stored in the data_array.
@TomFischer
[PL/SurfaceFlux] Clang format.
27ae7de
@TomFischer
[T/GWF] Rename update expected solution.
cba8478 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/GWF] Rename update expected solution.
de212ae 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/GWF] Rename update expected solution.
46cba82 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/GWF] Rename update expected solution.
3ac5b08 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/GWF] Rename update expected solution.
6d24874 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/GWF] Rename update expected solution.
7e540f8 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/HT] Rename and update expected solution.
4efc8e6 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/HT] Rename and update expected solution.
06f6861 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/HC] Rename and update expected solution.
351a715 
- Rename to better reflect the contained date.
- Expected solution update due to output of specific flux instead of flux.
@TomFischer
[T/PL/GWF] Relax tolerances in surface flux tests.
a7fbd39
@endJunction endJunction merged commit be937ec into ufz:master Mar 11, 2019
@TomFischer TomFischer deleted the FixBalanceIssue branch March 11, 2019 12:18
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endJunction endJunction endJunction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomFischer @ogsbot @endJunction