Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Solid Material Models from MFront #2259

Merged
merged 11 commits into from
Nov 12, 2018
Merged

Use Solid Material Models from MFront #2259

merged 11 commits into from
Nov 12, 2018

Conversation

chleh
Copy link
Collaborator

@chleh chleh commented Nov 6, 2018 •
edited
Loading

TODO

  • Reference solutions to remaining test cases
  • squash commits

Follow-up

  • MFront parameters (currently not supported by MGIS)
  • Read/write internal state variables
  • Maybe initially compute self-consistent internal state based on ICs
  • Enable CI-Tests
  • Non-isotropic materials (essentially only tests needed)
  • Other modelling hypotheses than 3D and plane strain

@chleh chleh changed the title MFront Use Solid Material Models from MFront Nov 7, 2018
@chleh chleh force-pushed the mfront2 branch 2 times, most recently from 4770eb8 to bc9a2ed Compare November 7, 2018 09:55
@chleh
Copy link
Collaborator Author

chleh commented Nov 7, 2018

Btw: Thanks to @thelfer for MGIS, and for @fparisio for discovering MGIS and for support with the tests.

@fparisio-zz
Copy link
Contributor

Mine was the easiest part ;) Thank @chleh for the implementation!

@thelfer
Copy link

thelfer commented Nov 7, 2018 •
edited
Loading

Hi everyone,
I am quite impressed that @chleh was able to use MGIS with has been developped quite recently without much focus on documentation !
Do not hesitate to make feed-backs and request new features, I will be happy to help !
I am planning to add proper support for orthotropic behaviours (by providing the free functions to rotate tensors). I'll do this just after finishing the python bindings. BTW, I also know that the generic interface has a few shortcomings that I need to tackle.
Regards,
Thomas

endJunction
endJunction reviewed Nov 8, 2018
View reviewed changes
MaterialLib/SolidModels/MFront/MFront.cpp
++r)
{
auto const R = OGSToMFront(r);
for (std::ptrdiff_t c = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why ptrdiff here, not an int (which is the type for rows/cols at compile time)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's somewhat mixed. Eigen's operator() uses Eigen::Index,
Eigen::Index by default is std::ptrdiff_t.

endJunction
endJunction approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pleasure to read nicely written code!

@endJunction endJunction merged commit 5027ab4 into ufz:master Nov 12, 2018
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endJunction endJunction endJunction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chleh @fparisio-zz @thelfer @ogsbot @endJunction