Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BC meshes post refactoring #2153

Merged
merged 12 commits into from
Jun 28, 2018
Merged

Move BC meshes post refactoring #2153

merged 12 commits into from
Jun 28, 2018

Conversation

endJunction
Copy link
Member

@endJunction endJunction commented Jun 25, 2018 •
edited
Loading

  • Removal of special Neumann BC for LIE: This simplifies the rest of the BoundaryCondition implementation.
  • Simplification of boundary condition/source terms builders.
  • Extract reading of the meshes in ProjectData and store as unique_ptr's.
  • Improve several other points related to the meshes and their usage in BCs.

This is preparation for the PR allowing multiple meshes to be given in the project file and used as BCs/STs and in general define multiple discrete domains of definition.

To be merged after the "constrained BCs" #2145.

TODO:

  • Update hash for the latest master including the LIE/Neumann BCs.

TomFischer
TomFischer approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@TomFischer TomFischer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! After resolving conflicts: ⏩

@endJunction
[PL] LIE; Remove special Neumann BC for disp.jump.
0c9a648 
The boundary condition is not used in any test so far
and the physical interpretation of that BC is difficult
at least.

The removal greatly simplifies few things.

The Dirichlet BC is still available.
@endJunction
[PL] Replace BCBuilder with createBC function.
d0004a4
@endJunction
[PL] Replace STBuilder with createST function.
5248729
@endJunction
[PL] Store vector of unique ptr to meshes in prj.
4575854
@endJunction
[A] PrjData: Move creation of meshes in own fct.
91da4d3 
This also allows to remove the _geoObjects member from the ProjectData.
@endJunction
[A] PD: Use anonymous ns instead of named+static.
ac20928
@endJunction
[A] PD: Split reading of single mesh.
50a61e9
@endJunction
[MGTL] Pass axial symmetry to constructed meshes.
4f7a85f 
The bulk mesh property must be set on the newly created
meshes. The bulk mesh is not available upon the mesh construction
and it is simpler to set the property afterwards, than
to pass it through two function calls.
@endJunction
[A] Add search length to construct mesh from geom.
ff43aba
@endJunction
[NL] MCM: Turn assert into error with expl. msg.
1e44809
@endJunction
[NL] DOF; Fix variable offsets for derived table.
60a897a 
The variable component offsets are absolute and the derived
DOF table must have all the bulk DOF table global component
offset for each variable.
@endJunction
[PL] BCs/STs; Add mesh name to error message.
2031e44
@endJunction endJunction merged commit 2171706 into ufz:master Jun 28, 2018
@endJunction endJunction deleted the MoveBCMeshesPostRefactoring branch June 28, 2018 20:05
bilke pushed a commit to bilke/ogs that referenced this pull request Jul 2, 2018
@endJunction @bilke
Merge pull request ufz#2153 from endJunction/MoveBCMeshesPostRefactoring
10a3dcd 
Move BC meshes post refactoring
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomFischer TomFischer TomFischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endJunction @ogsbot @TomFischer