Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated data submodule #2010

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Remove deprecated data submodule #2010

merged 2 commits into from
Dec 6, 2017

Conversation

bilke
Copy link
Member

@bilke bilke commented Dec 5, 2017

  • Removed git submodule Tests/Data
  • Renamed Tests/lfs-data to Tests/Data

Once merged I will setup an automatic update of the deprecated ufz/ogs-data with the changes from Tests/Data to make the lfs-stored files viewable on GitHub.

endJunction
endJunction approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must get out a message before merging it, otherwise people will be upset (again) about the Tests being moved around....

@bilke
Copy link
Member Author

bilke commented Dec 5, 2017

@endJunction ogs-devs mailing list?

@bilke
Copy link
Member Author

bilke commented Dec 5, 2017

@ufz/members

Please be aware of this change:

The folder Tests/Data will remain but its contents will be managed by Git LFS instead of a git submodule. This will ease the handling (especially in pull requests) of test data files. More information about git lfs at the community meeting next Tuesday or in the docs:

https://docs.opengeosys.org/docs/devguide/testing/test-data

TomFischer
TomFischer approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@TomFischer TomFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@endJunction endJunction merged commit c4f396f into ufz:master Dec 6, 2017
@bilke bilke deleted the remove-data-submodule branch December 6, 2017 11:37
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomFischer TomFischer TomFischer approved these changes

@endJunction endJunction endJunction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bilke @ogsbot @endJunction @TomFischer