-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative Jenkins pipeline #1976
Conversation
Looks good. One can still go to the "usual" pipeline steps and see the (overwhelming) details. |
623adff
to
8ec250b
Compare
bb85c31
to
bc74337
Compare
9fb41c0
to
8ffea2a
Compare
8ffea2a
to
d7951d0
Compare
Tests/NumLib/TestODEInt.cpp
Outdated
@@ -279,10 +279,13 @@ class NumLibODEIntTyped : public ::testing::Test | |||
|
|||
TYPED_TEST_CASE(NumLibODEIntTyped, TestCases); | |||
|
|||
// Temporarily disabled for PETSc issue # | |||
#ifndef USE_PETSC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: It would be better to disabled unit tests like this: ✅
#ifndef USE_PETSC
TYPED_TEST(NumLibODEIntTyped, T1)
#else
TYPED_TEST(NumLibODEIntTyped, DISABLED_T1)
#endif
This way the test will be compiled at least and ctest will tell you about it being disabled.
d7951d0
to
3bafec9
Compare
9426470
to
01fc616
Compare
Is now ready to merge. |
-l 30 is a ninja option which spawns no more compile processes if load is higher than 30.
011ec4b
to
83a99c0
Compare
OpenGeoSys development has been moved to GitLab. |
This is a PR migrating Jenkins scripts to the Declarative Pipeline which has some benefits:
Jenkinsfile
which at the moment contains basically the same logic asgcc-conan.groovy
andmsvc.groovy
I would like to hear your thoughts. If you agree to the migration I will finish this PR by migrating the remaining sub-jobs.
Caveats
Checks if running on a Unix-like node
which have no meaning for the user and clutter the view. Maybe this can be addressed in a future version of the declarative pipeline / blue ocean UI