Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarative Jenkins pipeline #1976

Merged
merged 22 commits into from
Nov 21, 2017
Merged

Declarative Jenkins pipeline #1976

merged 22 commits into from
Nov 21, 2017

Conversation

bilke
Copy link
Member

@bilke bilke commented Nov 1, 2017

This is a PR migrating Jenkins scripts to the Declarative Pipeline which has some benefits:

  • Easier to read, with some sane defaults for typical things such as setting environments, doing something as a post-step, ..., just have a look at the changed Jenkinsfile which at the moment contains basically the same logic as gcc-conan.groovy and msvc.groovy
  • Better visualization in the blue ocean Jenkins UI. You can click on the graph to see all steps which belong to a parallel sub-job. Also there are nice pages for tests and artifacts. I think this is a huge advantage, no more drilling down which step failed in the overwhelming pipeline steps view
  • Actively developed; it is advised to use the declarative pipeline for the general structure and if necessary more low-level code in the pipeline library

I would like to hear your thoughts. If you agree to the migration I will finish this PR by migrating the remaining sub-jobs.

Caveats

  • Steps can't be hidden from the pipeline view, e.g. there are lots of steps labelled Checks if running on a Unix-like node which have no meaning for the user and clutter the view. Maybe this can be addressed in a future version of the declarative pipeline / blue ocean UI

@endJunction
Copy link
Member

Looks good. One can still go to the "usual" pipeline steps and see the (overwhelming) details.

@bilke bilke force-pushed the declarative-pipeline branch 4 times, most recently from 623adff to 8ec250b Compare November 7, 2017 14:37
@bilke bilke force-pushed the declarative-pipeline branch 8 times, most recently from bb85c31 to bc74337 Compare November 16, 2017 08:42
@bilke bilke force-pushed the declarative-pipeline branch 2 times, most recently from 9fb41c0 to 8ffea2a Compare November 17, 2017 10:34
@@ -279,10 +279,13 @@ class NumLibODEIntTyped : public ::testing::Test

TYPED_TEST_CASE(NumLibODEIntTyped, TestCases);

// Temporarily disabled for PETSc issue #
#ifndef USE_PETSC
Copy link
Collaborator

@chleh chleh Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: It would be better to disabled unit tests like this: ✅

#ifndef USE_PETSC
TYPED_TEST(NumLibODEIntTyped, T1)
#else
TYPED_TEST(NumLibODEIntTyped, DISABLED_T1)
#endif

This way the test will be compiled at least and ctest will tell you about it being disabled.

@bilke bilke changed the title WIP: Declarative Jenkins pipeline Declarative Jenkins pipeline Nov 20, 2017
@bilke
Copy link
Member Author

bilke commented Nov 20, 2017

Is now ready to merge.

-l 30 is a ninja option which spawns no more compile processes if
load is higher than 30.
@bilke bilke merged commit cc4363e into ufz:master Nov 21, 2017
@bilke bilke deleted the declarative-pipeline branch November 21, 2017 12:16
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants