Various fixes from #1907 #1943
Merged
Various fixes from #1907 #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in future CMake version. Fixes a warning on CMake 3.9.
This reduces download times significantly as downloaded decreases from over 1 GB to around 60 MB.
Related: - ufz#1887 - https://stackoverflow.com/a/340683/80480 This slipped through as currently macOS is not tested via CI.
chleh
reviewed
Sep 11, 2017
| @@ -16,6 +16,7 @@ | |||
| [submodule "Tests/Data"] | |||
| path = Tests/Data | |||
| url = https://github.com/ufz/ogs-data | |||
| shallow = true | |||
There was a problem hiding this comment.
Although this PR is already merged: I understand the rationale behind setting shallow = true, but I assume that this can cause some problems, e.g., if a user just pushed something to a feature branch in ogs/data, then the shallow clone (with depth of one) of the submodule won't fetch the latest master commit, which will lead to nasty error messages at least. Or am I wrong?
There was a problem hiding this comment.
I don't think it will lead to problems because cmake scripts will fetch the missing data with depth=1.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cleanup #1907 a little bit...