Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test and lint Workflows #8

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Create test and lint Workflows #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
786b47b
create test and lint workflows
angel1254mc Oct 11, 2023
10f6d35
use setup-node w/ LTS version, use clean install
angel1254mc Oct 12, 2023
d63f458
fix missing newline
angel1254mc Oct 12, 2023
39b58ba
checkout repo before node setup
angel1254mc Oct 12, 2023
50457d3
remove extra spaces from lint workflow end
angel1254mc Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkout repo before node setup
  • Loading branch information
@angel1254mc
angel1254mc committed Oct 12, 2023
commit 39b58baac9ca3c25f4abd54cfdb0e56d39475d66
6 changes: 3 additions & 3 deletions .github/workflows/lint.workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout repo
uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question]: Vaguely familiar with GitHub actions. I was expecting to see something like setup-node here; is it not required? What happens without it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right, sorry for the oversight. I've gone ahead and added it in this latest commit /w Node 18 (LTS). Let me know if you think that's good 😄.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTS is good. FYI; if our project needed node itself we'd have it specified in package.json engines (and we'd want to match it to that) but since we don't this is first pick and LTS is the natural choice.


- name: Set up Node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Comment]: Should be after Checkout repo I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and fixed that in this latest commit 👍

uses: actions/setup-node@v3
with:
node-version: 18.x

- name: Checkout repo
uses: actions/checkout@v2

- name: Install dependencies
run: npm ci

Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/test.workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,16 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout repo
uses: actions/checkout@v2

- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 18.x

- name: Checkout repo
uses: actions/checkout@v2

- name: Install dependencies
run: npm ci

- name: Run tests
run: npm run test

Loading