Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nextjs #28

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Update nextjs #28

merged 3 commits into from
Nov 4, 2023

Conversation

Phantom0110
Copy link
Contributor

@Phantom0110 Phantom0110 commented Nov 2, 2023 •
edited
Loading

Updated next.js to version 14.0.1. Fixed lint issues. Resolves #23

@Phantom0110 Phantom0110 requested a review from a team November 2, 2023 04:36
@Phantom0110
Copy link
Contributor Author

Website seems to be running fine after update.

WillBAnders
WillBAnders requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@WillBAnders WillBAnders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update eslint-config-next as a Next dependency as well; otherwise LGTM.

@Phantom0110 Phantom0110 merged commit e0ab074 into master Nov 4, 2023
1 check passed
@Phantom0110 Phantom0110 deleted the update-nextjs branch November 4, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillBAnders WillBAnders WillBAnders approved these changes

Assignees

@Phantom0110 Phantom0110

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Next.js to v14
2 participants
@Phantom0110 @WillBAnders