Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: About page (title, description, and image) #12
Feature: About page (title, description, and image) #12
Changes from 1 commit
0c5365e
5ffb313
ad37c8f
989e992
2f25de8
6b86834
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nit]: As this is in
About.module.css
, there's no need to use anabout__
prefix. Also, preferkebab-case
for HTML/CSS identifiers (id
/class
) as with URLs (not fully sure the origin for this though).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS classNames have been changed to use camelCase as recommended by documentation: https://github.com/css-modules/css-modules#naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Comment]: I see the idea here. Normally, you would have some type of
container
class that would handle margin/padding for the page rather than apply it to specific elements (there's a few other tricks too for this to work better with mobile too). Anyways, keep this for now and we'll figure out a more general solution for all pages later as part of global styles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]: We can probably get a bit better with the name/alt - I happen to know this photo is from the Fall 2022 planning meeting. Suggestion:
I think this better represents the meaning of the photo rather than just being a description, but open to suggestions. Mainly looking ahead to when we (hopefully) have a gallery of images and need to do a better job sorting through that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillBAnders The alt text has since been updated. However, the name of the file is "group_photo.jpg", not "fall_2022_planning_meeting.jpg". Will this discrepancy be an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I would just recommend the more explicit name to help if/when we add a gallery with multiple pictures where it becomes more important to distinguish each one. But the file can always be renamed at the time; it's more of a callout to prefer more detailed names when possible.