Remove undefined conditions and unnecessary comments

ufssd · Dec 12, 2023 · d949dd3 · d949dd3
1 parent 6d9ae34
commit d949dd3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 17 deletions.
diff --git a/src/app/about/officer-data.ts b/src/app/about/officer-data.ts
@@ -31,7 +31,7 @@ const officerCardData: OfficerCardProps[] = [
     ],
   },
   {
-    position: "Tresurer",
+    position: "Treasurer",
     image: "public/officers/Stephen_Coomes.jpg",
     name: "Stephen Coomes",
     socialLinksData: [
@@ -387,7 +387,7 @@ export const officerData: { [key: string]: OfficerCardProps } = {
 };
 
 export const positionData: {
-  [key: string]: { [key: string]: OfficerCardProps | undefined };
+  [key: string]: { [key: string]: OfficerCardProps};
 } = {
   "Fall 2023": {
     President: officerData.yonas_bahre,

diff --git a/src/app/about/page.tsx b/src/app/about/page.tsx
@@ -6,24 +6,10 @@ import OfficerCard from "./officer-card";
 import { positionData } from "./officer-data";
 
 export default function About() {
-  // const officerCards = officerCardData.map((cardData) => (
-  //   <OfficerCard
-  //     key={cardData.position}
-  //     position={cardData.position}
-  //     image={cardData.image}
-  //     name={cardData.name}
-  //     socialLinksData={cardData.socialLinksData}
-  //   />
-  // ));
-
   const officerCardSection = Object.entries(positionData).map(
     ([semester, officers]) => {
       const officerCards = Object.entries(officers).map(
         ([position, officer]) => {
-          if (officer === undefined) {
-            return <div key={`${semester} ${position}`} />;
-          }
-
           return (
             <OfficerCard
               key={`${semester} ${position}`}
@@ -71,7 +57,6 @@ export default function About() {
       <section className={styles.officers}>
         <div className={styles.container}>
           <h2>Officers</h2>
-          {/* <div className={styles.cardContainer}>{officerCards}</div> */}
           {officerCardSection}
         </div>
       </section>