Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'model set run clock' routine in FV3 NUOPC cap. #967

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
# url = https://github.com/NOAA-EMC/fv3atm
# branch = develop
url = https://github.com/DusanJovic-NOAA/fv3atm
branch = use_ModelSetRunClock
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion FV3
4 changes: 0 additions & 4 deletions doc/UsersGuide/source/InputsOutputs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1146,10 +1146,6 @@ shows the following parameters that can be set in *model_configure* at run-time.
- frequency to output restart file or forecast hours to write out restart file
- integer
- 0 (0: write restart file at the end of integration; 12, -1: write out restart every 12 hours; 12 24 write out restart files at fh=12 and 24)
* - atm_coupling_interval_sec
- fast coupling interval in seconds for atmosphere
- real(8)
- 900
* - quilting
- flag to turn on quilt
- logical
Expand Down
4 changes: 3 additions & 1 deletion driver/UFS.F90
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,9 @@ PROGRAM UFS
CALL ESMF_TimeIntervalSet(restartOffset, h=fhrot, rc=RC)
ESMF_ERR_ABORT(RC)
CURRTIME = STARTTIME + restartOffset
call ESMF_ClockSet(CLOCK_MAIN, currTime=CURRTIME, rc=RC)
call ESMF_ClockSet(CLOCK_MAIN, currTime=CURRTIME, &
timeStep=(TIMESTEP-restartOffset), &
rc=RC)
ESMF_ERR_ABORT(RC)
endif
! ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
Expand Down
1 change: 0 additions & 1 deletion tests/parm/datm_cdeps_configure.IN
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ nhours_fcst: @[FHMAX]
RUN_CONTINUE: .false.
ENS_SPS: .false.
dt_atmos: @[DT_ATMOS]
atm_coupling_interval_sec: @[coupling_interval_fast_sec]
calendar: 'julian'
fhrot: @[FHROT]
nfhout: @[NFHOUT]
Expand Down
1 change: 0 additions & 1 deletion tests/parm/model_configure.IN
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ dt_atmos: @[DT_ATMOS]
calendar: 'julian'
restart_interval: @[RESTART_INTERVAL]
output_1st_tstep_rst: .false.
atm_coupling_interval_sec: @[coupling_interval_fast_sec]

quilting: @[QUILTING]
write_groups: @[WRITE_GROUP]
Expand Down
1 change: 0 additions & 1 deletion tests/parm/model_configure_fhout.IN
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ calendar: 'julian'
restart_interval: @[RESTART_INTERVAL]
fhrot: @[FHROT]
output_1st_tstep_rst: .false.
atm_coupling_interval_sec: @[coupling_interval_fast_sec]

quilting: @[QUILTING]
write_groups: @[WRITE_GROUP]
Expand Down
1 change: 1 addition & 0 deletions tests/parm/model_configure_regional.IN
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ start_hour: 00
start_minute: 0
start_second: 0
nhours_fcst: @[FHMAX]
fhrot: @[FHROT]

dt_atmos: 225
cpl: .false.
Expand Down
7 changes: 5 additions & 2 deletions tests/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,11 @@ fi
if [[ $skip_check_results = false ]]; then
check_results
else
echo "Test ${TEST_NR} ${TEST_NAME} RUN_SUCCESS" > ${REGRESSIONTEST_LOG}
echo;echo;echo >> ${REGRESSIONTEST_LOG}
echo >> ${REGRESSIONTEST_LOG}
grep "The total amount of wall time" ${RUNDIR}/out >> ${REGRESSIONTEST_LOG}
echo >> ${REGRESSIONTEST_LOG}
echo "Test ${TEST_NR} ${TEST_NAME} RUN_SUCCESS" >> ${REGRESSIONTEST_LOG}
echo;echo;echo >> ${REGRESSIONTEST_LOG}
fi

if [[ $SCHEDULER != 'none' ]]; then
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_wam
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ export H2O_PHYS=.true.
export NFHOUT=6
export NFHMAX=24
export NFHOUT_HF=6
export FHROT=18
2 changes: 2 additions & 0 deletions tests/tests/regional_restart
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ export TASKS=68
export INPES=10
export JNPES=6
export OUTPUT_FH="15 18 21 24"

export FHROT=12