Remove nemsio dependency #685
Conversation
| @@ -207,7 +202,7 @@ endif() | |||
| ### Data Components [NEMSdatm, CDEPS] | |||
| ############################################################################### | |||
| if(NEMSdatm) | |||
| add_subdirectory(DATM) | |||
| add_subdirectory(DATM/DATM) | |||
There was a problem hiding this comment.
Why do we need this change for removing nemsio?
There was a problem hiding this comment.
add_subdirectory(DATM) adds both DATM and tools which depends on nemsio. ufs-weather-model depends only on DATM/DATM
There was a problem hiding this comment.
I agree with this change, unless the tools are pulled out, which they should be. The tools should ideally reside in UFS_utils
There was a problem hiding this comment.
Or NEMS-datm or something like that.
There was a problem hiding this comment.
I don't believe that what is currently in the tools subdirectory is used at all. It is the original code I wrote to convert nesmio to netcdf for the DATM.
The code which is currently used to generate the DATM files resides in the utilities subdirectory of the DATM-MOM6-CICE6 repo. That also contains the utility to create the SCRIP file for the DATM (gen_scrip) although I'm not 100% sure it is used for CDEPS. It is the utilities subdirectory which would need to get moved to ufs-utils.
There was a problem hiding this comment.
@binli2337 @DeniseWorthen can we remove tools directory under https://github.com/noaa-emc/nemsdatm to avoid confusion?
There was a problem hiding this comment.
Yes, I believe we can & should remove the tools subdirectory.
|
Machine: jet |
* Add default namelist with SPP entries. * Changes necessary to run with SPP * Typo fix in generate script. * Changes to implement SPP. * Add comment regarding use of SPP. * Pass N_VAR_SPP to the var_defns.sh file. * Add spp_wts_pbl to the FV3_GSD_SAR SDF diag_table file * Remove the contents of the &nam_spperts stanza and n_var_spp from the namelist when not using SPP. * Remove SPP namelist entries from the template input.nml file. These values are now handled in the generate script if using SPP. * Add MYNN SFC pattern variable to the diag_table file for the FV3_GSD_SAR SDF * Add 'sfc' perturbation option to SPP * Add iseed array to namelist generation * Changes to add "rad" and "gwd" SPP perturbations. * Add SPP and ad-hoc stochastic physics to SDFs. * Add LSM SPP functionality to the SRW App. * Add random number generation for LSM SPP iseeds in ensemble mode. * Fix undeclared variable for LSM SPP. * Add if statement for LSM SPP namelist entries and set fhcyc to 999 if LSM SPP is turned on. * Modify how namelist settings are applied for LSM SPP. * Fix implementation of fhcyc changes. * Typo fix. * Add do_gsl* namelist entries to YAML file for FV3_HRRR SDF. * Remove diss_est from the diag table files since it's unavailable for now. * Change LSM SPP perturbation seed to be the same as all other SPP. * Changes to FV3_HRRR field_table * Change to the FV3_HRRR field_table file * Update name for SPP block in input.nml * Change SPP_LSM_* to LSM_SPP_* * Remove space. * Update descriptions of LSM perturbations. * Shut off PET file generation. * Modifications for land and SPP perturbations (templates, namelists, default values, etc.) * Remove diss_est from diag_table files and remove the FV3_GSD_SAR and FV3_GSD_v0 diag_table files. * Fix in setup.sh for LSM SPP * Update Thompson MP SPP settings. * Add back FV3_GSD_SAR and FV3_GSD_v0 SDFs. Will be removed in future, separate PR. * Requested modifications to the input.nml template and in-line documentation changes. * Fix check for LSM SPP namelist settings * Fix to LSM SPP namelist check. * Changes request based on PR review. * Changes requested in PR review. * Variable descriptions. * Fix comment formatting. * Fix MET/METplus/obs paths in machine files to allow for user-defined settings in config.sh * Only add/modify stochastic physics namelist entries when running with SPP, LSM SPP, SPPT, SHUM, or SKEB.
…er-1 platforms. (#685) Implemented config changes for SRW CMAQ users on cheyenne. These changes load the new shared conda environment 'regional_workflow_cmaq' for tasks that require the netcdf4 python package and its dependencies. This update saves each individual user from having to create the appropriate conda environment to run CMAQ. This should be a non-breaking change for non-CMAQ users, and for all non-cheyenne users. Similar config changes will be required on the other tier-1 platforms. Co-authored-by: Paddy Mccarthy <paddy@cheyenne6.cheyenne.ucar.edu>
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
Remove nemsio from the FV3 write component. nemsio is legacy file format that is being deprecated. Since there are no regression tests using nemsio file format, no change of answers is expected.
Issue(s) addressed
#207
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?