Ensure consistency between model namelist and CCPP suite definition file #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-model into consistency_redo
climbfuji
requested review from
junwang-noaa and
DusanJovic-NOAA
and removed request for
junwang-noaa
climbfuji
added
the
Waiting for Reviews
|
Ready to merge - but please wait for CI tests to complete. |
junwang-noaa
approved these changes
May 19, 2021
DusanJovic-NOAA
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR only updates the submodule pointers for the changes described in NCAR/ccpp-physics#655 and NOAA-EMC/fv3atm#298.
No changes to the results, no new input data.
Issue(s) addressed
Fixes NCAR/ccpp-physics#653.
Testing
Regression tests were run on 05/17/2021 on hera.intel, all tests passed. Full regression tests will be run on all tier-1 platforms.
Dependencies
NCAR/ccpp-physics#655
NCAR/ccpp-physics#661
NOAA-EMC/fv3atm#298
NOAA-EMC/fv3atm#298
#577