Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/public-v1: bug fix for threading issue in stochastic physics #55

Conversation

climbfuji
Copy link
Collaborator

This PR only updates the submodule pointers (and .gitmodules for the code review). For a description, see NOAA-EMC/fv3atm#62.

@climbfuji
Copy link
Collaborator Author

Regression tests passed on Cheyenne using both GNU and Intel. Hera is now in maintenance it seems, I cannot log in and check the results of the tests (kicked them off last night).

rt_cheyenne_gnu.log
rt_cheyenne_intel.log

@climbfuji
Copy link
Collaborator Author

I think we can start merging the fv3atm PR, and wait with the final ufs-weather-model PR until hera comes back and I can get the logs.

@junwang-noaa junwang-noaa merged commit 7f2d467 into ufs-community:release/public-v1 Feb 11, 2020
@climbfuji
Copy link
Collaborator Author

Ok, this PR didn't have the regression test logs from hera.intel before it was merged. I am attaching them here, all tests pass.

rt_hera_intel.log
Compile_hera.intel.log
RegressionTests_hera.intel.log

Please let me know if you want me to make a quick follow-up PR to commit Compile_hera.intel.log and RegressionTests_hera.intel.log. Thanks

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Feb 11, 2020 via email

@climbfuji
Copy link
Collaborator Author

See here: #57

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Feb 11, 2020 via email

climbfuji added a commit to climbfuji/ufs-weather-model that referenced this pull request Jun 29, 2020
…rrfs_tests

Jet build config updates (contains ufs-community#53 update the descriptions of the GSD_SAR_v1 and RRFS_v0 tests)
climbfuji added a commit to climbfuji/ufs-weather-model that referenced this pull request Dec 30, 2020
…fs-community#55)

Code is identical to original/current code in the authoritative repository (NOAA-PSD, branch master)
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/ufs-weather-model that referenced this pull request Oct 22, 2021
…all that caused a reproducibility issue. (ufs-community#55)

Co-authored-by: Chan-hoo.Jeon <chan-hoo.jeon@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants