Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global-workflow detect_machine.sh to keep consistent between projects #2111

Closed

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Jan 22, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch. RegressionTests_hera.log
  • Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

Bring in the global-workflow detect_machine.sh to keep consistent between projects.

Commit Message

Bring in the global-workflow detect_machine.sh to keep consistent between projects. (Closes #2096 )

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Normal

Blocking Dependencies

None

Git Issues Fixed By This PR

Changes

Subcomponent (with links)

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
FAILED REGRESSION TESTS

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review January 23, 2024 01:59
@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Jan 23, 2024
@BrianCurtis-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA
Copy link
Collaborator Author

@HenryWinterbottom-NOAA Here is the PR.

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA I see cheyenne in detect_machine.sh. We cleaned up cheyenne. Syncing issue?

@BrianCurtis-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA I see cheyenne in detect_machine.sh. We cleaned up cheyenne. Syncing issue?

This is a shared file between global-workflow and UFSWM now, so i'll confirm with them if they need to support Cheyenne still.

Do you know if this still hold true on Gaea?:

elif [[ -d /lustre && -d /ncrc ]] ; then
  # We are on GAEA.
  MACHINE_ID=gaea

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA I see cheyenne in detect_machine.sh. We cleaned up cheyenne. Syncing issue?

This is a shared file between global-workflow and UFSWM now, so i'll confirm with them if they need to support Cheyenne still.

Do you know if this still hold true on Gaea?:

elif [[ -d /lustre && -d /ncrc ]] ; then
  # We are on GAEA.
  MACHINE_ID=gaea

I think it should be: /lustre is gone with f2

elif [[ -d /gpfs && -d /ncrc ]] ; then

@BrianCurtis-NOAA
Copy link
Collaborator Author

Cheyenne is off, forgot it happened end of Dec. And I'll make the change for Gaea, thanks.

@BrianCurtis-NOAA BrianCurtis-NOAA self-assigned this Jan 26, 2024
ulmononian pushed a commit to ulmononian/ufs-weather-model that referenced this pull request Feb 5, 2024
ulmononian pushed a commit to ulmononian/ufs-weather-model that referenced this pull request Feb 6, 2024
ulmononian pushed a commit to ulmononian/ufs-weather-model that referenced this pull request Feb 6, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 6, 2024

@BrianCurtis-NOAA can you sync up branch? We will try to combine with #2115

ulmononian pushed a commit to ulmononian/ufs-weather-model that referenced this pull request Feb 6, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 6, 2024

@ulmononian manually picked up files change from this pr. @BrianCurtis-NOAA you can check at #2115

ulmononian pushed a commit to ulmononian/ufs-weather-model that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring in detect_machine.sh from global workflow for consistency across the community.
2 participants