Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding atmw to the ort scripts #1747

Closed
wants to merge 65 commits into from
Closed

Adding atmw to the ort scripts #1747

wants to merge 65 commits into from

Conversation

SadeghTabas-NOAA
Copy link
Collaborator

@SadeghTabas-NOAA SadeghTabas-NOAA commented May 10, 2023 •
edited
Loading

Description

Currently the ORT system supports global/regional atmosphere standalone and coupled S2S applications. In this PR, the ORT will support ATMW application by running ORT tests (threads, decomposition, MPI tasks, restart and debug tests) with atmwav_control_noaero_p8

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@zach1221
Copy link
Collaborator

Hi, @SadeghTabas-NOAA

I'm running the below against this PR on Cheyenne with intel/gnu compilers and will let you know if I experience any issues.
./opnReqTest -n atmwav_control_noaero_p8 -c thr,dcp,mpi,rst,dbg

@SadeghTabas-NOAA
Copy link
Collaborator Author

SadeghTabas-NOAA commented May 17, 2023 •
edited
Loading

Hi, @SadeghTabas-NOAA

I'm running the below against this PR on Cheyenne with intel/gnu compilers and will let you know if I experience any issues. ./opnReqTest -n atmwav_control_noaero_p8 -c thr,dcp,mpi,rst,dbg

@zach1221 please wait, I still have some updates. I'll let you know once I'm done and the PR is reasy for testing.

@zach1221
Copy link
Collaborator

@SadeghTabas-NOAA Sure, no problem. Holding off.

@SadeghTabas-NOAA SadeghTabas-NOAA marked this pull request as draft May 30, 2023 15:26
@SadeghTabas-NOAA SadeghTabas-NOAA marked this pull request as ready for review June 1, 2023 09:17
@SadeghTabas-NOAA SadeghTabas-NOAA added No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Jun 1, 2023
@DeniseWorthen DeniseWorthen mentioned this pull request Jun 12, 2023
Merged
37 tasks
@BrianCurtis-NOAA
Copy link
Collaborator

@SadeghTabas-NOAA Can you attach logs from running ORT on this new test?

@SadeghTabas-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA If you remember I told you the ORT dbg test (develop branch) does not pass due to exceeding wall clock. That's why I was not able to upload the logs here. I'll try I again now.

@SadeghTabas-NOAA
Copy link
Collaborator Author

@DeniseWorthen @BrianCurtis-NOAA @zach1221 I've uploaded the log for atmw ort test on hera (all the tests passed).

zach1221 pushed a commit that referenced this pull request Jun 14, 2023
@DeniseWorthen
Update CMEPS; add ATM ORT test (was #1747); update Gaea stack locatio…
251ec56 
…n (was #1758) (#1752)

* update CMEPS w/ fix for error condition

* adding atmw to ORT

*update cmeps build to implement check4nans feature using module stored in cdeps repo

* Gaea software stack location update after C3 and C4 partition upgrades

* added CMP_DATAONLY variable for ORT FHZ test

* added CMEPS and WAVE restart file for ATMW ORT RST test

* add ORT log for atmwav_control_noaero_p8 ORT test
-----
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: Sadegh Sadeghi Tabas <31417680+SadeghTabas-NOAA@users.noreply.github.com>
Co-authored-by: Natalie Perlin <Natalie.Perlin@noaa.gov>
@zach1221
Copy link
Collaborator

@SadeghTabas-NOAA combined PR#1752 has been merged into community develop. I will go ahead and close this PR.

@zach1221 zach1221 closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA left review comments

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

Assignees
No one assigned
Labels
No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support ORT for ATMW application
4 participants
@SadeghTabas-NOAA @zach1221 @BrianCurtis-NOAA @DeniseWorthen