Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/AQM.v7] Capability for AQM to run using a debug build of UFSWM #1631

Merged

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Feb 27, 2023

Description

This PR brings in the capability for UFS-AQM to run in debug mode.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

regional_atmaq_debug
regional_atmaq

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA self-assigned this Feb 27, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Capability addition to run using a debug build of UFSWM Capability for AQM to run using a debug build of UFSWM Feb 27, 2023
@BrianCurtis-NOAA
Copy link
Collaborator Author

RegressionTests_wcoss2.intel.log
RegressionTests_wcoss2.intel.proof.log

Proof log shows no debug baseline and fails regional_atmaq
log shows reproduces with new baselines.

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review March 9, 2023 19:29
@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Mar 9, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Capability for AQM to run using a debug build of UFSWM [production/AQM.v7] Capability for AQM to run using a debug build of UFSWM Mar 13, 2023
Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 6c7ee83 into ufs-community:production/AQM.v7 Mar 14, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA deleted the debug_run branch March 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants