Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hailcast code in FV3/atmos_cubed_sphere #1164

Closed
wants to merge 2 commits into from

Conversation

ywangwof
Copy link

@ywangwof ywangwof commented Apr 8, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

To produce the hail size diagnostic output, this namelist block should be added to input.nml.

&fv_diagnostics_nml
do_hailcast = .true.
/

and this entry should be added to diag_table

"gfs_dyn", "hailcast_dhail_max", "HAILCAST_DHAIL", "fv3_history2d", "all", .false., "none", 2

If either input.nml or diag_table is not changed, it will do nothing.

Description

Add FV3-HAILCAST code with FV3/atmos_cubed_sphere for hail size diagnostic output. It will not change the answers and no library update is needed.

Issue(s) addressed

see PR #164.

Testing

It was tested on Jet and a NSSL machine - Odin with Intel compiler. No regression tests needed since it will not change the model, but just add a diagnostic output.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@junwang-noaa
Copy link
Collaborator

@ywangwof Please update the submodule .gitmodules in your ufs-weather-model branch to point to your fv3 branch. Please see example here. You need to do the same for your fv3 branch (pointing to your dycore branch).

@ywangwof
Copy link
Author

ywangwof commented Apr 8, 2022

.gitmodules was modified for both PRs. Thanks.

@junwang-noaa
Copy link
Collaborator

The dycore PR#164 was committed in ufs-weather-model PR#1156. The PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants