gwdps.f bug fix #1035
gwdps.f bug fix #1035
Conversation
|
@SMoorthi-emc Can you check if your fv3 submodule is pointing to your fv3atm branch? The same for stochastic physics? |
|
Done.
…On Thu, Feb 3, 2022 at 9:55 PM Jun Wang ***@***.***> wrote:
@SMoorthi-emc <https://github.com/SMoorthi-emc> Can you check if your fv3
submodule is pointing to your fv3atm branch? The same for stochastic
physics?
—
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYV3ADDHSEWCXO7GUK3UZM52ZANCNFSM5NNBH5MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
@SMoorthi-emc Please sync the CMEPS component. |
|
Already done this morning.
Moorthi
…On Fri, Feb 4, 2022 at 8:39 AM Jun Wang ***@***.***> wrote:
@SMoorthi-emc <https://github.com/SMoorthi-emc> Please sync the CMEPS
component.
—
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYSAAN2D62ATJ5YN4ALUZPJH7ANCNFSM5NNBH5MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
I still see CMEPS differences in this PR, https://github.com/ufs-community/ufs-weather-model/pull/1035/files. |
|
I think there is a problem somewhere. I am up to date with branch
"emc/develop".
I don't see "959c64" version and when I pull "emc/develop" is says already
updated.
Also, history on this branch only shows
"* df272f1 2022-02-03 | Merge remote-tracking branch 'escomp/master' into
feature/fixup_commit_history (HEAD, origin/emc/develop, origin/HEAD)
[denise.worthen]
|\
| * 7419333 2022-02-01 | Add Wave slow loop coupling and Field Exchanges
for waves in nems (#266) [Denise Worthen]"
So, where is this new branch ?
…On Fri, Feb 4, 2022 at 9:29 AM Jun Wang ***@***.***> wrote:
I still see CMEPS differences in this PR,
https://github.com/ufs-community/ufs-weather-model/pull/1035/files.
—
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYRGIWEH2CA7YLWPJLDUZPPC7ANCNFSM5NNBH5MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
FYI, I ran full RTs on Hera/Intel (using latest develop branches of ufs-weather-model and fv3atm with the ccpp-physics branch associated with this PR) to double-check that the expected tests are the only ones that fail. I found this to be the case -- that the only tests that failed did so in check_result and all called gwdps_run. See, e.g., the following list: |
|
Given the expected results that #1037 doesn't change the answer and this PR needs new baselines for the list copied above, is it OK if I create new PRs for ufs-weather-model, fv3atm, and ccpp-physics that combine these two to save time testing/merging? @SMoorthi-emc @junwang-noaa |
|
I have no issue if they are combined as they are independent changes.
Moorthi
…On Fri, Feb 4, 2022 at 2:35 PM Grant Firl ***@***.***> wrote:
Given the expected results that #1037
<#1037> doesn't
change the answer and this PR needs new baselines for the list copied
above, is it OK if I create new PRs for ufs-weather-model, fv3atm, and
ccpp-physics that combine these two to save time testing/merging?
—
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYROTDWNLW6I35V5MS3UZQTBBANCNFSM5NNBH5MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
It appears that now the hash for CMEPS is correct and consistent with that in my branch. So, how did this happen? What was wrong before? |
|
This PR is combined with #1037. |
…fs-community#1035) Remove develop branch CODEOWNERS for @BrianCurtis-NOAA as maintainer for only production/AQM.v7 branch
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
Fixes a bug in gwdps.f under ccpp-physics
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs