Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing information in the regression tests #459

Closed
junwang-noaa opened this issue Mar 9, 2021 · 4 comments · Fixed by #364
Closed

Timing information in the regression tests #459

junwang-noaa opened this issue Mar 9, 2021 · 4 comments · Fixed by #364
Labels
enhancement New feature or request

Comments

@junwang-noaa
Copy link
Collaborator

Description

In the regression test log files, it would be good if the timing information can be added. This information will allow developers to track when code updates cause significant slowdown

Solution

In the run output files, there is a total wall clock time "The total amount of wall time", we can grab that line to the each test log information.

Related to

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related.

@junwang-noaa junwang-noaa added the enhancement New feature or request label Mar 9, 2021
@DusanJovic-NOAA
Copy link
Collaborator

$ git diff rt_utils.sh
diff --git a/tests/rt_utils.sh b/tests/rt_utils.sh
index 52f9dd8..a6e982a 100755
--- a/tests/rt_utils.sh
+++ b/tests/rt_utils.sh
@@ -327,6 +327,10 @@ check_results() {
 
   fi
 
+  echo                                               >> ${REGRESSIONTEST_LOG}
+  grep "The total amount of wall time" ${RUNDIR}/out >> ${REGRESSIONTEST_LOG}
+  echo                                               >> ${REGRESSIONTEST_LOG}
+
   echo "Test ${TEST_NR} ${TEST_NAME} ${test_status}" >> ${REGRESSIONTEST_LOG}
   echo                                               >> ${REGRESSIONTEST_LOG}
   echo "Test ${TEST_NR} ${TEST_NAME} ${test_status}"

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Mar 10, 2021 via email

@DeniseWorthen
Copy link
Collaborator

We could combine this with the change for Issue #228?

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Mar 10, 2021 via email

pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this issue Apr 4, 2023
* Added a new suite definition file: suite_FV3_HAFS_v0_thompson_tedmf_gfdlsf.xml. This SDF is a legacy hwrf SDF but only the GFDL surface layer scheme and the Thompson scheme are kept.
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
…"--cpus-per-task" value. (#459)

* Create user-defined OMP variables.

* Add OMP variables to make_sfc_climo task

* Move OMP stanza in exregional_run_fcst.sh file

* Add "OpenMP" to comment.

* Make --cpus-per-task a user-defined variable.

* Revert to "srun" for the RUN_FCST task on Jet

* Remove export commands from ex-scripts, remove OMP options from make_grid and make_orog tasks.

* Add OMP options to make_orog ex-script.

* Remove KMP_AFFINITY setting from WCOSS_CRAY block.

* Remove exports from all commands in exregional_make_orog.sh and update comments in all relevant ex-scripts.
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
* Bug fix forecast directory deletion.

* Bug fix in build only mode.

* Remove unused sample.nc

* Make setup_WE2E work irrespective of conda activation.

* Fix the bug fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants