Skip to content

Compiler warnings may not be suppressed #1984

Closed
@DusanJovic-NOAA

Description

@DusanJovic-NOAA

Currently in the top-level cmake and in atmos_cube_sphere cmake we use the -nowarn flag (Intel compiler) which suppress all compiler warnings.

$ grep -r nowarn .
./cmake/Intel.cmake:set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -g -traceback -fpp -fno-alias -auto -safe-cray-ptr -ftz -assume byterecl -nowarn -sox -align array64byte -qno-opt-dynamic-align")
./FV3/atmos_cubed_sphere/cmake/compiler_flags_Intel_Fortran.cmake:set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -g -traceback -fpp -fno-alias -auto -safe-cray-ptr -ftz -assume byterecl -nowarn -sox -align array64byte -qno-opt-dynamic-align ${${kind}_flags}")

According to "NCEP Central Operations WCOSS Implementation Standards" this is not allowed (page 15 section IV B. (5)):

"Code must compile without errors or warnings. Errors and warnings may not be suppressed, and the compiler warning level ("-W" options) must be at least the default one."

We should remove this flag (from ufs-weather-model and atmos_cubed_sphere) and start working on eliminating all warnings.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions