Skip to content

RRTMGP radiation scheme fails with OpenMP  #1687

Open
@pj-gdit

Description

Description

We are running UFS on WCOSS2 HPE/Cray systems to evaluate RRTMGP radiation scheme and find that it fails in mo_gas_concentrat routine in longwave code if more than 1 OMP thread is used. shortwave code (and other RRTMGP routines executed before that) are OK.

I see in the initial comment in PR #418 , mention of adding OMP CRITICAL directives for thread safety (among other changes), however I do not see any OMP CRITICAL directives in the RRTMGP radiation code in the latest development branch. Are PR $418 in latest develop?

To Reproduce:

What compilers/machines are you seeing this with?
Intel 19.1.3.304
Give explicit steps to reproduce the behavior.

  1. Run with RRTMGP and 1 OpenMP thread (OMP_NUM_THREADS=1) is successful
  2. Run with RRTMGP and 2 OpenMP threads and if fails with segfault in mo_gas_concentrat

Additional context

See PR #418

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions