Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the run output error file #1662

Closed
junwang-noaa opened this issue Mar 20, 2023 · 5 comments
Closed

clean up the run output error file #1662

junwang-noaa opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@junwang-noaa
Copy link
Collaborator

Description

Currently the model RT tests output two run files: err and out. The err file should only contain message when the model failed. All the run information goes to out file. However the err file now contains non-error message from physics and UPP. This needs to be fixed.
e.g., in the err file:

0: Using non-aerosol-aware version of Thompson microphysics
0: calling table_ccnAct routine
0: creating qc collision eff tables
0: creating rain evap table
0: creating ice converting to snow table
0: creating rain collecting graupel table
0: creating freezing of water drops table
0: ... DONE microphysical lookup tables

144: in readxml,bf readxml,size(post_avblflds%param)= 0
144: xml_perl_data read Post flat file
144: allocate paramset to : 2
144: allocate param to : 47
...

To Reproduce:

Run a regression test e.g. control_p8. Check the err and out files in the run directory.

Additional context

Output

@junwang-noaa junwang-noaa added the bug Something isn't working label Mar 20, 2023
@DusanJovic-NOAA DusanJovic-NOAA self-assigned this Mar 23, 2023
@junwang-noaa junwang-noaa changed the title clean up the run output error and out files clean up the run output error file Apr 10, 2023
@junwang-noaa
Copy link
Collaborator Author

The code updates were committed in PR#1690, the issue is closed. A new issue will be created to clean up upp prints in ufs wm out file.

@junwang-noaa
Copy link
Collaborator Author

The prints from ccpp physics need to be moved to the out file too:

0: Using non-aerosol-aware version of Thompson microphysics
0: calling table_ccnAct routine
0: creating qc collision eff tables
0: creating rain evap table
0: creating ice converting to snow table
0: creating rain collecting graupel table
0: creating freezing of water drops table
0: ... DONE microphysical lookup tables

@Qingfu-Liu Would you please change all the:

write(0,*) ...
to
write(*,*) ...

in module_mp_thompson.F90 as the prints in those lines are not error messages. Thanks

@Qingfu-Liu
Copy link
Collaborator

@junwang-noaa
OK. I will make the change

@Qingfu-Liu
Copy link
Collaborator

Qingfu-Liu commented May 8, 2023 via email

@Qingfu-Liu
Copy link
Collaborator

I have committed the changes to PR#65. The only program changed is module_mp_thompson.F90 in this new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants