Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create regression test for two-way wave-atm coupling for a FV3-MOM6-CICE5-WW3 test #31

Closed
JessicaMeixner-NOAA opened this issue Mar 4, 2020 · 10 comments
Closed

create regression test for two-way wave-atm coupling for a FV3-MOM6-CICE5-WW3 test #31

JessicaMeixner-NOAA opened this issue Mar 4, 2020 · 10 comments
Assignees
@JessicaMeixner-NOAA

Comments

@JessicaMeixner-NOAA
Copy link
Collaborator

This test will have wave-atm two-way coupling added to a new compset for FV3-MOM6-CICE5-WW3.

When wave-ocean coupling is added, it will be added to this test and this test will not be retained.
@JessicaMeixner-NOAA JessicaMeixner-NOAA self-assigned this Mar 4, 2020
@JessicaMeixner-NOAA
Copy link
Collaborator Author

The update in fv3atm PR for wave to atm feedback, also has a bug fix which changes answers. Has a new baseline already been created for ufs-s2s-model that corresponds to this commit or should I go ahead and make that while making the new test?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 5, 2020 via email

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Sounds good. If @binli2337 points me to the long runs I'll make sure the runs get analyzed. Test for the s2s with WW3-ATM coupling is in progress....

@junwang-noaa junwang-noaa mentioned this issue Mar 6, 2020
Closed
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this issue Mar 9, 2020
Closed
@JianKuang-Intelsat JianKuang-Intelsat mentioned this issue Mar 9, 2020
Closed
@lgannoaa
Copy link
Collaborator

@JessicaMeixner-NOAA and @binli2337 ,

After research on the issue that some fix files were pointed from personal location. I found the GFS using same solution in linking/copy fix files. GFS team used the fix file from glopara group account local location on supporting machine. Therefore, files point to Bin.Li should be changed to a group account. Please see the modified link_fv3gfs.sh below:

pwd:
/scratch1/NCEPDEV/global/Lin.Gan/git/coupled-workflow-crow
Found file pointed to Bin.Li personal location:
./fix/fix_mom6 -> /scratch2/NCEPDEV/climate/Bin.Li/S2S/fix/fix_prep_benchmark3/fix_mom6
./fix/fix_cice5 -> /scratch2/NCEPDEV/climate/Bin.Li/S2S/fix/fix_prep_benchmark3/fix_cice5
./fix/fix_ocnice -> /scratch2/NCEPDEV/climate/Bin.Li/S2S/fix/fix_prep_benchmark3/fix_ocnice
./fix/fix_fv3grid -> /scratch2/NCEPDEV/climate/Bin.Li/S2S/fix/fix_prep_benchmark3/fix_fv3grid

Research:
In link_fv3gfs.sh, GFS using "glopara" local location to copy/link the fix files:

FIX_DIR="/scratch1/NCEPDEV/global/glopara/fix"
$LINK $FIX_DIR/* .

Will use the same solution.

File purposed to change:
/scratch1/NCEPDEV/global/Lin.Gan/git/coupled-workflow-crow/sorc/link_fv3gfs.sh

Please let me know if you have any questions.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@lgannoaa I agree we should not be pointing to anything in a personal directory. Do we want to use the glopara account or I'm slowly working on getting access to climate group account for myself and a few others.

If you want to put it in the globpara, that's fine I just need to figure out what is different (if anything) from the /scratch1/NCEPDEV/global/glopara/fix and ours and what is added, and make sure the added files have been cleaned up so we aren't keep a lot of files we don't need.

@lgannoaa
Copy link
Collaborator

@JessicaMeixner-NOAA I recommend to put those fix files under climate group account. The GFS team already justified their solution of linking/copy fix files from glopara. This solution will be in-line with EE2 review requirements.

@lgannoaa
Copy link
Collaborator

@JessicaMeixner-NOAA @binli2337
I discovered the ice*.nc files are not bit identical. Please contact developer to change these NC file to not be time stamped. It can be made bit identical. Please create an issue for this item. Thanks

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@lgannoaa can you use a different comparison method for that file then? The contents minus the datestamp should be identical. This is a CICE5 output and we have plans to move to CICE6 soon so this is a low - to - no priority item for us to address for CICE5.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Also @lgannoaa I just noticed this is all for workflow, and this issue is for a ufs-s2s-model regression test. Can we move the workflow conversations to an issue for the workflow?

@lgannoaa
Copy link
Collaborator

Ok thanks @JessicaMeixner-NOAA
I understand CICE5 is not main concern at this time. As regard to where this discussion should be, I do not know. Please fell free to remove the conversion as need. The EE2 does require bid identical results.

JessicaMeixner-NOAA added a commit to JessicaMeixner-NOAA/ufs-s2s-model that referenced this issue Mar 18, 2020
@JessicaMeixner-NOAA
adding WW3 regression test following 1 day benchmark RT Issue ufs-com…
2ec617b 
…munity#31
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this issue Mar 22, 2020
Merged
binli2337 added a commit that referenced this issue Mar 24, 2020
@JessicaMeixner-NOAA @binli2337
Add two regression tests to add benchmark regtest and wav-atm couplin…
a59b6cf 
…g test (#61)

* Update ufs-s2s-model

* update FV3, MOM6 and NEMS

* update FV3 to latest develop
Update datesuite tests to include 2013 tests
update baseline area on hera

* Adding a regression test that matches benchmark physics Issue #46

* changing test to 1 day instead of 2

* updating files to match ufs-weather-model develop branch

* moving to the latest NEMS

* adding WW3 regression test following 1 day benchmark RT Issue #31

* rolling back the REGTEST-FINGERPRINT.md and pointing to baseline

* Updated FV3 and NEMS components.

* Add log files.

* update to latest NEMS

* update README

* remove doc folder

* updating post to latest version and a few other files to match ufs-weather

* logs for hera

* moved update-20200321 to develop-20200322 in baseline area

* reverting IMFSHALCNV and IMFDEEPCNV to parameters in input.mom6.nml

* log files confirming last change was okay

Co-authored-by: Bin.Li <bin.li@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaMeixner-NOAA JessicaMeixner-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JessicaMeixner-NOAA @lgannoaa @junwang-noaa