Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add MET/METplus to Jet #799

Conversation

EdwardSnyder-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Added MetPlus file paths to the Jet machine file in the develop branch. A similar PR #797 was approved for the release branch.

TESTS CONDUCTED:

Ran MET_verification and MET_ensemble_verification successfully on Jet.

DEPENDENCIES:

None.

DOCUMENTATION:

No documentation changes are needed.

ISSUE (optional):

CONTRIBUTORS (optional):

@EdwardSnyder-NOAA EdwardSnyder-NOAA changed the title add metplus paths [develop] Add METplus to Jet Jun 23, 2022
@EdwardSnyder-NOAA EdwardSnyder-NOAA marked this pull request as ready for review June 23, 2022 15:08
@EdwardSnyder-NOAA EdwardSnyder-NOAA changed the title [develop] Add METplus to Jet [develop] Add MET/METplus to Jet Jun 23, 2022
@willmayfield
Copy link
Collaborator

Did you check the MET outputs and logs? I had hoped to put this change in #779 but ran into errors from MET, even though the workflow tasks succeeded. I was thinking it needs an appropriate run_vx.local modulefile and/or updates to the miniconda environment.

@EdwardSnyder-NOAA
Copy link
Collaborator Author

Did you check the MET outputs and logs? I had hoped to put this change in #779 but ran into errors from MET, even though the workflow tasks succeeded. I was thinking it needs an appropriate run_vx.local modulefile and/or updates to the miniconda environment.

Hi @willmayfield - I didn't check the logs or outputs. What sort of errors did you receive? I'm noticing the ModuleNotFoundError: No module named 'dateutil' error is in most of the vx logs.

@willmayfield
Copy link
Collaborator

Hi @willmayfield - I didn't check the logs or outputs. What sort of errors did you receive? I'm noticing the ModuleNotFoundError: No module named 'dateutil' error is in most of the vx logs.

Yep, that's what I see too.

@EdwardSnyder-NOAA
Copy link
Collaborator Author

Added modulefiles/tasks/jet/run_vx.local script, which removed ModuleNotFoundError: No module named 'dateutil' errors and resulted in a successful run of both the MET_verification and MET_ensemble_verification tests.

Copy link
Collaborator

@willmayfield willmayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared a few MET stat files to the same test on Hera. There were very small numerical differences, likely within reason between platforms, and the MET logs looked fine. Thanks Ed!

@EdwardSnyder-NOAA
Copy link
Collaborator Author

Thanks @willmayfield for doing the comparison!

@EdwardSnyder-NOAA EdwardSnyder-NOAA merged commit 2e336c1 into ufs-community:develop Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants