[develop]: Remove shell workflow. #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielabdi-noaa
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
jwolff-ncar and
dmwright526
as code owners
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
from
aab1006 to
4ecc0e8
Compare
danielabdi-noaa
requested review from
gspetro-NOAA,
natalie-perlin and
EdwardSnyder-NOAA
as code owners
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
4 times, most recently
from
04e78b2 to
104c34f
Compare
|
WE2E using the config.community.sh file succeeded on Hera. |
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
3 times, most recently
from
d43cfe2 to
36e42b7
Compare
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
from
36e42b7 to
8659e07
Compare
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
2 times, most recently
from
7fc93ac to
cd22251
Compare
…fs-community#775) * update input namelist of chgres_cube * update diag_table templates * update scripts * back to original * specify miniconda version on Jet
danielabdi-noaa
force-pushed
the
feature/remove_shell_workflow
branch
from
cd22251 to
9f88f60
Compare
JeffBeck-NOAA
added
the
Tested on Cheyenne
JeffBeck-NOAA
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR removes the shell workflow. Almost all of the duplicate files under
ush/are removed, choosing either the shell or python version. Two files still need both versions since it turned out to be difficult to use the python versions in job scripts withoutregional_workflowenvironment activated there. The PR will make updates much easier because there is only one workflow generation path to worry about.TESTS CONDUCTED:
I have run tests successfully on HERA, ORION and JET. The set of tests are taken from a recent run using the shell workflow generation path done in PR #744 slighltly modified to use the new "custom_ESG/GFDLgrid" names.
Out of 56 tests
these are the failures where the reason is mentioned in brackets
HERA
0 failures
ORION
1 failure
JET
only 5 failures which is a lot of improvement since last time I tried.
DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE (optional):
None
CONTRIBUTORS (optional):
@christinaholtNOAA @venitahagerty