Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old scripts from homedir and add static to FIX dir #93

Merged
merged 14 commits into from
May 13, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented May 7, 2024

Description

  • Clean up the old scripts from the home directory.
  • Change LANDDA_INPUTS to HOME/fix (no need to add link inputs for ctest any more).

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufsLand.fd (NOAA-EPIC/ufs-land-driver-emc-dev)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • vector2tile_converter.fd (NOAA-PSL/land-vector2tile)
  • none

Linked PR's and Issues:

Resolve Issue #51 and #58

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • CI
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented May 7, 2024

Test project /work/noaa/epic/chjeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed   11.68 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed   18.42 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   79.45 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    5.00 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed   11.90 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed    9.00 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  512.91 sec

100% tests passed, 0 tests failed out of 7

@chan-hoo chan-hoo requested a review from jkbk2004 May 7, 2024 16:47
@chan-hoo chan-hoo linked an issue May 7, 2024 that may be closed by this pull request
@chan-hoo chan-hoo changed the title Clean up old scripts from home directory Clean up old scripts from homedir and add static to FIX dir May 9, 2024
@chan-hoo
Copy link
Collaborator Author

chan-hoo commented May 9, 2024

Test project /work/noaa/epic/chjeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed    5.89 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed   14.87 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   74.32 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    4.16 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed   13.20 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed    9.84 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  395.61 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 518.09 sec

@chan-hoo chan-hoo linked an issue May 9, 2024 that may be closed by this pull request
@jkbk2004
Copy link
Collaborator

@chan-hoo Eventually, we need to clean up all vector2tile code base including https://github.com/NOAA-EPIC/ufs-land-driver-emc-dev/tree/6c6bf43012362c8fc349d7b52d9afeeb13352241. But I agree to clean up script level first. Changes at ctest level are needed but we can follow up in next PR.

@chan-hoo chan-hoo merged commit 7fe418f into ufs-community:develop May 13, 2024
2 checks passed
@chan-hoo chan-hoo deleted the feature/cleanup branch May 16, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants