Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHGRES_CUBE: range check SST when using GRIB2 #89

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

The GFS GRIB2 pgb files can contain SSTs colder than 271.2 K (because they are interpolated from the master file using bilinear interpolation). Add range checking to the routine that reads the GRIB2 files. For more details see issue #59.

Add range check to SST in GRIB2 surface read routine.
Use Xu Li's recommeded values of 271.2K and 310K.
Merge branch 'develop' into feature/chgres_sst
Merge branch 'develop' into feature/chgres_sst
Remove some diagnostic print from ./chgres_cube.fd/input_data.F90
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Mar 17, 2020
@GeorgeGayno-NOAA
Copy link
Collaborator Author

Xu, have you had a chance to look at this? No hurry.

Merge branch 'develop' into feature/chgres_sst
Copy link
Contributor

@XuLi-NOAA XuLi-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

George,

The range of 271.2 K to 310.0 K for water temperature applied is appropriate to me.

Copy link
Contributor

@XuLi-NOAA XuLi-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range check applied to water temperature is OK to me.

Copy link
Contributor

@XuLi-NOAA XuLi-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range check applied to the water temperature is OK to me.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

The range check applied to the water temperature is OK to me.

Thanks for your review.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 2d7f796 into ufs-community:develop Mar 27, 2020
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/chgres_sst branch March 27, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants