Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESMF 8.2.0 library (feature/esmf_8_2_0) #622

Merged

Conversation

MinsukJi-NOAA
Copy link
Contributor

@MinsukJi-NOAA MinsukJi-NOAA commented Jan 28, 2022

DESCRIPTION OF CHANGES:

Use ESMF 8.2.0 library. Motivation for this change comes from #143.

TESTS CONDUCTED:

Consistency tests have been run on all 5 supported platforms for those utilities that are affected by the ESMF library: chgres_cube and grid_gen. The results are reported here

DEPENDENCIES:

None

DOCUMENTATION:

N/A

ISSUE:

Fixes #621
Part of #143.

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the workflow files to use ESMF 8.2.0. I can help with that.

modulefiles/build.wcoss_dell_p3.intel.lua Show resolved Hide resolved
modulefiles/build.wcoss_cray.intel Outdated Show resolved Hide resolved
@MinsukJi-NOAA
Copy link
Contributor Author

We should update the workflow files to use ESMF 8.2.0. I can help with that.

I just committed these changes in 62522c8.

@GeorgeGayno-NOAA
Copy link
Collaborator

@MinsukJi-NOAA I see some of the checks failed because of memory leaks. I don't think you did anything wrong. Let me investigate what is going on.

@MinsukJi-NOAA
Copy link
Contributor Author

@MinsukJi-NOAA I see some of the checks failed because of memory leaks. I don't think you did anything wrong. Let me investigate what is going on.

Thanks!

@GeorgeGayno-NOAA
Copy link
Collaborator

@MinsukJi-NOAA I see some of the checks failed because of memory leaks. I don't think you did anything wrong. Let me investigate what is going on.

I am able to suppress the memory links. I can update your branch.

@GeorgeGayno-NOAA
Copy link
Collaborator

@kgerheiser By upgrading to ESMF v8.2.0, we are getting failed tests due to memory leaks. There were no ufs_utils code changes, so I am blaming the ESMF library. Do you agree? To get the tests to pass, I have to keep adding items to the suppression file: GeorgeGayno-NOAA@04b7a0d Is there a better way?

@kgerheiser
Copy link
Contributor

I would agree, it's probably ESMF. Memory check flags are temperamental and it's easy to encounter situations like this. It's either keep adding to the suppression file or turn them off.

ignore memory leaks associated with ESMF v8.2.0.

Fixes ufs-community#621.
@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 26cd024 into ufs-community:develop Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ESMF 8.2.0 library
3 participants