-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ESMF 8.2.0 library (feature/esmf_8_2_0) #622
Use ESMF 8.2.0 library (feature/esmf_8_2_0) #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the workflow files to use ESMF 8.2.0. I can help with that.
I just committed these changes in 62522c8. |
@MinsukJi-NOAA I see some of the checks failed because of memory leaks. I don't think you did anything wrong. Let me investigate what is going on. |
Thanks! |
I am able to suppress the memory links. I can update your branch. |
@kgerheiser By upgrading to ESMF v8.2.0, we are getting failed tests due to memory leaks. There were no ufs_utils code changes, so I am blaming the ESMF library. Do you agree? To get the tests to pass, I have to keep adding items to the suppression file: GeorgeGayno-NOAA@04b7a0d Is there a better way? |
I would agree, it's probably ESMF. Memory check flags are temperamental and it's easy to encounter situations like this. It's either keep adding to the suppression file or turn them off. |
ignore memory leaks associated with ESMF v8.2.0. Fixes ufs-community#621.
DESCRIPTION OF CHANGES:
Use ESMF 8.2.0 library. Motivation for this change comes from #143.
TESTS CONDUCTED:
Consistency tests have been run on all 5 supported platforms for those utilities that are affected by the ESMF library:
chgres_cube
andgrid_gen
. The results are reported hereDEPENDENCIES:
None
DOCUMENTATION:
N/A
ISSUE:
Fixes #621
Part of #143.